Skip to content

Add fix of process objects for processes that have exited. #16946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PaulHigin merged 4 commits into from
Mar 2, 2022
Merged

Add fix of process objects for processes that have exited. #16946

PaulHigin merged 4 commits into from
Mar 2, 2022

Conversation

@PaulHigin
Copy link
Contributor

@PaulHigin PaulHigin commented Mar 1, 2022 •
edited
Loading

PR Summary

This PR fixes the Enter-PSHostProcess and Get-PSHostProcessInfo cmdlets so that they will ignore processes that have already exited.

PR Context

.NET GetProcess method sometimes returns process objects for processes that have recently exited. In addition, the exited process object will throw if some properties are accessed (process.ProcessName), causing the cmdlet to fail and in turn causing some tests to fail.
This fix ignores already exited process objects.

This appears to be a .NET 7 regression, and I have created an Issue in that repo:
dotnet/runtime#66096

PR Checklist

@ghost ghost assigned TravisEz13 Mar 1, 2022
@PaulHigin PaulHigin requested a review from daxian-dbw March 1, 2022 23:40
@PaulHigin PaulHigin assigned PaulHigin and unassigned TravisEz13 Mar 1, 2022
daxian-dbw
daxian-dbw approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I saw the same error thrown from the Get-PSHostProcessInfo test at https://dev.azure.com/powershell/PowerShell/_build/results?buildId=95294&view=logs&j=65e467a7-433b-584d-c8f4-72fcd5732f9d&t=6a14d04a-9a6d-5c41-f839-531117eeb032&l=3913

Will this change fix that too?

@PaulHigin
Copy link
Contributor Author

PaulHigin commented Mar 2, 2022

@daxian-dbw Yes, I intended to fix both Enter-PSHostProcess and Get-PSHostProcessInfo tests. The tests results I see above appear to no longer have those test failures. I'll check in these changes once I have verified.

@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Mar 2, 2022

This PR has 53 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Small
Size       : +34 -19
Percentile : 21.2%

Total files changed: 2

Change summary by file extension:
.cs : +33 -18
.resx : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@PaulHigin PaulHigin added this to the 7.3.0-preview.2 milestone Mar 2, 2022
@ghost ghost removed this from the 7.3.0-preview.2 milestone Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@PaulHigin PaulHigin added this to the 7.3-Consider milestone Mar 2, 2022
@ghost ghost removed this from the 7.3-Consider milestone Mar 2, 2022
@ghost
Copy link

ghost commented Mar 2, 2022

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@PaulHigin
Copy link
Contributor Author

PaulHigin commented Mar 2, 2022

Failing tests are known issues. This change fixes the Enter-PSHostProcess and Get-PSHostProcessInfo test failures.

@PaulHigin PaulHigin merged commit df460b7 into PowerShell:master Mar 2, 2022
@PaulHigin PaulHigin deleted the fix-pshost branch March 2, 2022 21:53
@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Mar 21, 2022
@ghost
Copy link

ghost commented Mar 21, 2022

🎉v7.3.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees

@PaulHigin PaulHigin

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PaulHigin @daxian-dbw @iSazonov @TravisEz13