Skip to content

Conversation

@ngharo
Copy link
Contributor

@ngharo ngharo commented Feb 17, 2022

Set the RPM digest algorithm to SHA256 when distribution target is Red Hat.

PR Context

fpm is used to build the rpm package. By default, the rpm digest will use md5. md5 is not FIPS compliant. If I specify sha256 as an option during the build I am able to install correctly.

Fixes #15866

PR Checklist

@ghost ghost added the Review - Needed The PR is being reviewed label Feb 25, 2022
@ghost
Copy link

ghost commented Feb 25, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@vanlinnj
Copy link

Subscribing to this PR for updates.

@pull-request-quantifier-deprecated

This PR has 1 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -0
Percentile : 0.4%

Total files changed: 1

Change summary by file extension:
.psm1 : +1 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13
Copy link
Member

@ngharo Thank you for fixing this.

@ghost ghost removed the Review - Needed The PR is being reviewed label Apr 20, 2022
@TravisEz13 TravisEz13 disabled auto-merge April 21, 2022 16:49
@TravisEz13
Copy link
Member

windows packaging failures are unrelated

@TravisEz13
Copy link
Member

/backport to release/v7.2.4

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022

Started backporting to release/v7.2.4: https://github.com/PowerShell/PowerShell/actions/runs/2242305687

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions

This comment was marked as outdated.

@TravisEz13
Copy link
Member

/backport to release/v7.2.4

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022

Started backporting to release/v7.2.4: https://github.com/PowerShell/PowerShell/actions/runs/2242314317

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@ghost
Copy link

ghost commented May 23, 2022

🎉v7.3.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PowerShell package in yum repository needs to have a payload digest.

4 participants