Skip to content

Bump NJsonSchema from 10.5.2 to 10.6.9 #16888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 2 commits into from
Feb 16, 2022
Merged

Bump NJsonSchema from 10.5.2 to 10.6.9 #16888

TravisEz13 merged 2 commits into from
Feb 16, 2022
+3 −3

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 16, 2022

Bumps NJsonSchema from 10.5.2 to 10.6.9.

Release notes

Sourced from NJsonSchema's releases.

NJsonSchema v10.6.9

NJsonSchema v10.6.8

  • Fixed C# inheritance code generation for System.Text.Json
  • Other fixes

NJsonSchema v10.6.7

No release notes provided.

NJsonSchema v10.6.6

  • Fix bug in Namotion.Reflection

NJsonSchema v10.6.5

  • AdditionalProperties are only added on the base class (#1451)
  • Fix ConvertCSharpDocs multi-line regression (#1463)

NJsonSchema v10.6.4

  • Fixed toolchain version output in code generators

NJsonSchema v10.6.3

  • More performance improvements
  • Added UseXmlDocumentation and ResolveExternalXmlDocumentation settings in NJsonSchema
    • Breaking change: Use these settings instead of XmlDocsExtensions.ResolveFromNuGetCacheOrDotNetSdk

NJsonSchema v10.6.2

  • Some performance improvements

NJsonSchema v10.6.1

No release notes provided.

NJsonSchema v10.6.0

  • Breaking change: Migrate from DotLiquid to Fluid (reasons: much faster code generation & more strict liquid implementation)
    • You need to migrate custom templates: Replace elseif with elsif, fix newline handling (have a look at the updates templates in the repository).
  • Minor bug fixes
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump NJsonSchema from 10.5.2 to 10.6.9
503251a 
Bumps [NJsonSchema](https://github.com/RicoSuter/NJsonSchema) from 10.5.2 to 10.6.9.
- [Release notes](https://github.com/RicoSuter/NJsonSchema/releases)
- [Commits](RicoSuter/NJsonSchema@v10.5.2...v10.6.9)

---
updated-dependencies:
- dependency-name: NJsonSchema
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 16, 2022
@ghost ghost assigned iSazonov Feb 16, 2022
@dependabot dependabot bot mentioned this pull request Feb 16, 2022
Closed
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Feb 16, 2022

This PR has 6 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +3 -3
Percentile : 2.4%

Total files changed: 2

Change summary by file extension:
.csproj : +1 -1
.json : +2 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 enabled auto-merge (squash) February 16, 2022 18:25
@TravisEz13 TravisEz13 merged commit fbae40d into master Feb 16, 2022
@TravisEz13 TravisEz13 deleted the dependabot/nuget/NJsonSchema-10.6.9 branch February 16, 2022 19:01
@ghost
Copy link

ghost commented Feb 24, 2022

🎉v7.3.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@adityapatwardhan adityapatwardhan

@iSazonov iSazonov

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TravisEz13 @adityapatwardhan @iSazonov