Skip to content

Add a couple fixes to generic method invocation #16822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 2 commits into from
Feb 3, 2022
Merged

Add a couple fixes to generic method invocation #16822

adityapatwardhan merged 2 commits into from
Feb 3, 2022

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Feb 1, 2022 •
edited
Loading

PR Summary

Fix #16809
Follow up on #12412

Add a couple fixes to generic method invocation:

  1. For a generic type argument, if it doesn't exist at compilation time but available at run time, it should work as expected.
  2. For a generic type argument, if it doesn't exist at all, we should report error about which type name cannot be resolved.
  3. Make sure the tests actually run and fix all the tests.

@vexx32 It turns out the tests you added didn't run at all because of this:

PowerShell/test/powershell/Language/Parser/MethodInvocation.Tests.ps1

Lines 3 to 5 in 8af0834

if ( $IsCoreCLR ) {
return
}

PR Checklist

@ghost ghost assigned TravisEz13 Feb 1, 2022
@daxian-dbw daxian-dbw requested a review from vexx32 February 1, 2022 00:09
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Feb 1, 2022
vexx32
vexx32 approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@vexx32 vexx32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 Can't believe I didn't catch that... does that mean none of the tests in that file were running, then? Glad you caught that!

The changes here look good to me on the surface, thanks for adding this in! 💖

iSazonov
iSazonov reviewed Feb 1, 2022
View reviewed changes
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Feb 1, 2022

This PR has 252 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +132 -120
Percentile : 65.2%

Total files changed: 5

Change summary by file extension:
.cs : +59 -51
.resx : +0 -3
.ps1 : +73 -66

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@SeeminglyScience
Copy link
Collaborator

SeeminglyScience commented Feb 1, 2022

  1. For a generic type argument, if it doesn't exist at all, we should report error about which type name cannot be resolved.

What about generic constraint violations? e.g.

[enum]::GetName[object]([object]::new())

Calling MakeGenericMethod([object]) throws this error message:

GenericArguments[0], 'System.Object', on 'System.String GetName[TEnum](TEnum)' violates the constraint of type 'TEnum'.

Is that surfaced?

@daxian-dbw
Copy link
Member Author

daxian-dbw commented Feb 1, 2022 •
edited
Loading

Is that surfaced?

Sorta :) The error message still has room to improve, for example, list out the specified type parameters (which may be too long to make the message less readable).

image

@SeeminglyScience
Copy link
Collaborator

SeeminglyScience commented Feb 1, 2022

Sorta :) The error message still has room to improve, for example, list out the specified type parameters (which may be too long to make the message less readable).

I was expecting the generic method not found message so I'll take it! 😁

@adityapatwardhan adityapatwardhan merged commit 35ad64e into PowerShell:master Feb 3, 2022
@daxian-dbw daxian-dbw deleted the generic branch February 3, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov left review comments

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

+1 more reviewer

@vexx32 vexx32 vexx32 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor PSMethodInvocationConstraints to make it able to work with types that not available at compilation time but loaded at runtime

6 participants

@daxian-dbw @SeeminglyScience @adityapatwardhan @iSazonov @vexx32 @TravisEz13