-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Change logic for updating .NET. #16808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
also include a message when it looks like a new .NET is not going to be used.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
| Update-DevContainer | ||
| } | ||
| else { | ||
| Write-Verbose -Verbose -Message $dotnetUpdate.Message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Write-Verbose -Verbose -Message $dotnetUpdate.Message | |
| Write-Verbose -Verbose -Message "No update needed. DotNet update message: $($dotnetUpdate.Message)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an update may actually be needed, so i wouldn't want to say "update needed" when the update message says "update manually"
|
🎉 Handy links: |
also include a message when it looks like a new .NET is not going to be used.
PR Summary
The workflow to update .NET is sometimes difficult to debug from the log files. This PR attempt to make it more obvious when we are not going to update .net. Also the workflow should provide a better indication of what file should be inspected for issues.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).