Skip to content

Prevent tab completion if the word to complete is a single dash #16781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulHigin merged 5 commits into from
Feb 9, 2022
Merged

Prevent tab completion if the word to complete is a single dash #16781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4fb7d85
added code to prevent tab completion if the word to complete is a sin…
ayousuf23 Jan 20, 2022
122b4d9
Merge branch 'master' into issue-16577
ayousuf23 Jan 22, 2022
f93b445
added a test for testing tab completion if the word to complete is a …
ayousuf23 Jan 29, 2022
6df17cf
Merge branch 'master' into issue-16577
ayousuf23 Jan 31, 2022
8772f47
Minor update and add comment
daxian-dbw Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,7 +1329,8 @@ internal static List<CompletionResult> CompleteCommandArgument(CompletionContext
context.Options.Remove("LiteralPaths");
}

if (context.WordToComplete != string.Empty && context.WordToComplete.Contains('-'))
// The word to complete contains a dash and it's not the first character. We try command names in this case.
if (context.WordToComplete.IndexOf('-') > 0)
{
var commandResults = CompleteCommand(context);
if (commandResults != null)
Expand Down
7 changes: 7 additions & 0 deletions test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,6 +1378,13 @@ dir -Recurse `
$res = TabExpansion2 -inputScript $inputStr -cursorColumn $inputStr.Length
$res.CompletionMatches | Should -BeNullOrEmpty
}

It "A single dash should not complete to anything" {
function test-{}
$inputStr = 'git -'
$res = TabExpansion2 -inputScript $inputStr -cursorColumn $inputStr.Length
$res.CompletionMatches | Should -BeNullOrEmpty
}
}

Context "Tab completion error tests" {
Expand Down