-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update macOS build image and root folder for build #16609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@adityapatwardhan Does this also have to be changed in 'mac-package-build.yml'? |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@PaulHigin - good catch.. pushed. |
|
Release is blocked on this. Merging. |
| condition: succeeded() | ||
| pool: | ||
| vmImage: internal-macos-10.14 | ||
| vmImage: internal-macos-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be macos-11
| - powershell: | | ||
| $dirSeparatorChar = [system.io.path]::DirectorySeparatorChar | ||
| $nativePath = "${dirSeparatorChar}PowerShell" | ||
| $nativePath = "${env:HOME}${dirSeparatorChar}PowerShell" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to move this under the agent working directory at one point.
|
🎉 Handy links: |
# Conflicts: # tools/releaseBuild/azureDevOps/templates/mac.yml
# Conflicts: # tools/releaseBuild/azureDevOps/templates/mac.yml
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
PR Summary
Update the build vmImage for the release build. Since catalina onwards, we cannot create folders at root. change the build to create folder under $HOME instead
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).