-
Notifications
You must be signed in to change notification settings - Fork 8.1k
WebCmdlets: empty body should not be added for Get Methods #16563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To comply with RFC7230, empty body should not be added for Get Methods
...t.PowerShell.Commands.Utility/commands/utility/WebCmdlet/Common/WebRequestPSCmdlet.Common.cs
Outdated
Show resolved
Hide resolved
TravisEz13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
…Cmdlet/Common/WebRequestPSCmdlet.Common.cs Co-authored-by: Travis Plunk <travis.plunk@microsoft.com>
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
Oh, it is dup of #16587 and it seems the fix cover more scenarios but haven't tests. We need resolve the conflict and combine the PRs. |
|
Closing this PR as #16587 covers this and has necessary test changes |
|
@VeVrX Thanks for your contribution! Sorry for the PR conflict. |
PR Summary
Fix #15186 - To comply with RFC7230, empty body should not be added for Get Methods
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).