-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Bring back pwsh.exe for framework dependent packages to support Start-Job
#16535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+97
−9
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
42d5e86
Bring back pwsh.exe for framework dependent packages to support Start…
adityapatwardhan 99ac966
Update wix file
adityapatwardhan 0952b51
Add release tests for fxd packages
adityapatwardhan 407fa3e
Fix tests
adityapatwardhan 3c8785a
Fix stage dependencies
adityapatwardhan 9b23259
Address CR comments
adityapatwardhan c7ca2bc
Fix typo
adityapatwardhan 489b8bf
Add value for the hashtable item
adityapatwardhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
tools/releaseBuild/azureDevOps/templates/release-ValidateFxdPackage.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| parameters: | ||
| jobName: "" | ||
| displayName: "" | ||
| imageName: "" | ||
| packageNamePattern: "" | ||
|
|
||
| jobs: | ||
| - job: ${{ parameters.jobName }} | ||
| displayName: ${{ parameters.displayName }} | ||
| pool: | ||
| vmImage: ${{ parameters.imageName }} | ||
| steps: | ||
| - checkout: self | ||
| clean: true | ||
|
|
||
| - task: DownloadPipelineArtifact@2 | ||
| inputs: | ||
| source: specific | ||
| project: PowerShellCore | ||
| pipeline: '696' | ||
| preferTriggeringPipeline: true | ||
| runVersion: latestFromBranch | ||
| runBranch: '$(Build.SourceBranch)' | ||
| artifact: finalResults | ||
| patterns: '${{ parameters.packageNamePattern }}' | ||
| path: '$(Pipeline.Workspace)/releasePipeline/finalResults' | ||
|
|
||
| - pwsh: | | ||
| Get-ChildItem -Path '$(Pipeline.Workspace)/releasePipeline/finalResults' -Recurse | ||
| displayName: Capture downloaded package | ||
|
|
||
| - pwsh: | | ||
| $destPath = New-Item '$(Pipeline.Workspace)/releasePipeline/finalResults/fxd' -ItemType Directory | ||
| $packageNameFilter = '${{ parameters.packageNamePattern }}' | ||
|
|
||
| if ($packageNameFilter.EndsWith('tar.gz')) { | ||
| $package = @(Get-ChildItem -Path '$(Pipeline.Workspace)/releasePipeline/finalResults/*.tar.gz') | ||
| Write-Verbose -Verbose "Package: $package" | ||
| if ($package.Count -ne 1) { | ||
| throw 'Only 1 package was expected.' | ||
| } | ||
| tar -xvf $package.FullName -C $destPath | ||
| } | ||
| else { | ||
| $package = @(Get-ChildItem -Path '$(Pipeline.Workspace)/releasePipeline/finalResults/*.zip') | ||
| Write-Verbose -Verbose "Package: $package" | ||
| if ($package.Count -ne 1) { | ||
| throw 'Only 1 package was expected.' | ||
| } | ||
| Expand-Archive -Path $package.FullName -Destination "$destPath" -Verbose | ||
| } | ||
| displayName: Expand fxd package | ||
|
|
||
| - pwsh: | | ||
| $packageNameFilter = '${{ parameters.packageNamePattern }}' | ||
| $pwshExeName = if ($packageNameFilter.EndsWith('tar.gz')) { 'pwsh' } else { 'pwsh.exe' } | ||
| $actualOutput = & $pwshExeName -c 'Start-Job -ScriptBlock { "1" } | Wait-Job | Receive-Job' | ||
| Write-Verbose -Verbose "Actual output: $actualOutput" | ||
| if ($actualOutput -ne 1) { | ||
| throw "Actual output is not as expected" | ||
| } | ||
| displayName: Test package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we removed this because it was not signed.. we should sign it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.. let me check the test build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the packaging code.