Skip to content

Conversation

@MartinGC94
Copy link
Contributor

PR Summary

Adds completion for the keywords following the Using keyword (assembly, module, namespace).
Example: using <Tab> results in using assembly

PR Checklist

@ghost ghost assigned anmenaga Nov 24, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 29, 2021
MartinGC94 and others added 2 commits December 1, 2021 21:54
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 10, 2021
@ghost
Copy link

ghost commented Dec 10, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@MartinGC94
Copy link
Contributor Author

I've updated the tooltips to show the syntax which will probably help with discovery of the namespace/type alias feature if/when that gets merged. I've also added completion for the type keyword.
While the namespace/type alias feature hasn't been merged yet, I don't want to end up in a situation where this and that feature gets merged and then having to wait for months for a separate PR to get merged to add completion for type and fixing the tooltip for namespace.

@iSazonov
Copy link
Collaborator

/rebase

@ghost ghost removed the Review - Needed The PR is being reviewed label Dec 13, 2022
@iSazonov
Copy link
Collaborator

@MartinGC94 Please rebase to get latest updates.

@MartinGC94
Copy link
Contributor Author

@iSazonov GetResultForIdentifier has changed from an instance method to a static method since I made this branch so I can no longer access the _tokens field and that's why it's now failing.
There are 3 approaches I can take to fix this:

  1. Change it back to an instance method so I can access the _tokens field.
  2. Update GetResultForIdentifier with a Tokens parameter
  3. Move my CompleteUsingKeywords method out of GetResultForIdentifier

Do you have any preferences? I'm personally leaning towards 3.

@iSazonov
Copy link
Collaborator

Do you have any preferences? I'm personally leaning towards 3.

No objections.

@pull-request-quantifier-deprecated

This PR has 81 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +79 -2
Percentile : 32.4%

Total files changed: 3

Change summary by file extension:
.cs : +51 -1
.resx : +18 -0
.ps1 : +10 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov iSazonov merged commit 9a7db33 into PowerShell:master Dec 20, 2022
@iSazonov iSazonov assigned iSazonov and unassigned anmenaga Dec 20, 2022
@ghost
Copy link

ghost commented Mar 14, 2023

🎉v7.4.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants