Skip to content

Add an approval for releasing build-info json #16351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TravisEz13 merged 1 commit into from
Nov 1, 2021
Merged

Add an approval for releasing build-info json #16351

TravisEz13 merged 1 commit into from
Nov 1, 2021

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Nov 1, 2021 •
edited
Loading

PR Summary

Add an approval check for releasing the build-info json

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Nov 1, 2021
@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Nov 1, 2021

This PR has 11 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +8 -3
Percentile : 4.4%

Total files changed: 1

Change summary by file extension:
.yml : +8 -3

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 merged commit 3071718 into PowerShell:master Nov 1, 2021
@adityapatwardhan adityapatwardhan added Backport-7.2.x-Approved CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.2.x-Done and removed Backport-7.2.x-Consider labels Nov 1, 2021
@ghost
Copy link

ghost commented Nov 8, 2021

🎉v7.2.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@adityapatwardhan @TrapGodBrim
Add an approval for releasing build-info json (PowerShell#16351)
25b1c73
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@adityapatwardhan
Add an approval for releasing build-info json (PowerShell#16351)
bec5c36
@TravisEz13
Copy link
Member

TravisEz13 commented May 4, 2022

/backport to release/v7.0.11

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022 •
edited by unfurl-links bot
Loading

Started backporting to release/v7.0.11: https://github.com/PowerShell/PowerShell/actions/runs/2271011076

GitHub
PowerShell for every system! Contribute to PowerShell/PowerShell development by creating an account on GitHub.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

@TravisEz13 backporting to release/v7.0.11 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Add an approval for releasing build-info json
Using index info to reconstruct a base tree...
M	tools/releaseBuild/azureDevOps/releasePipeline.yml
Falling back to patching base and 3-way merge...
Auto-merging tools/releaseBuild/azureDevOps/releasePipeline.yml
CONFLICT (content): Merge conflict in tools/releaseBuild/azureDevOps/releasePipeline.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add an approval for releasing build-info json
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

TravisEz13 pushed a commit that referenced this pull request May 9, 2022
@adityapatwardhan @TravisEz13
Add an approval for releasing build-info json (#16351)
6d7e41a 
# Conflicts:
#	tools/releaseBuild/azureDevOps/releasePipeline.yml
@ghost
Copy link

ghost commented May 17, 2022

🎉v7.0.11 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

Assignees

@TravisEz13 TravisEz13

Labels

Backport-7.0.x-Done Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityapatwardhan @TravisEz13 @daxian-dbw