-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Fix global tool and SDK tests in release pipeline #16342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix global tool and SDK tests in release pipeline #16342
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@daxian-dbw Please re-review |
|
🎉 Handy links: |
|
🎉 Handy links: |
PR Summary
Global tool tests needed the DOTNET_ROOT variable to be set.
SDK tests needed the internal nuget feed URL to be inserted.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).