Skip to content

Does PSStyle early initialization less expensive #16320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 2 commits into from
Oct 28, 2021
Merged

Does PSStyle early initialization less expensive #16320

daxian-dbw merged 2 commits into from
Oct 28, 2021

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Oct 28, 2021 •
edited
Loading

PR Summary

Improve startup scenario. It is a perf regression after #13758.

Before the PR:
image

PR Context

PR Checklist

@iSazonov iSazonov added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Oct 28, 2021
@iSazonov iSazonov marked this pull request as ready for review October 28, 2021 06:41
daxian-dbw
daxian-dbw reviewed Oct 28, 2021
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a couple feedback.

It is a perf regression after #15897.

Are you sure it's regressed by #15897? That PR doesn't seem to be related. Please update your PR description if that should be corrected.

@iSazonov
Copy link
Collaborator Author

iSazonov commented Oct 28, 2021

It is a perf regression after #15897.

Are you sure it's regressed by #15897? That PR doesn't seem to be related. Please update your PR description if that should be corrected.

There was added static InitialSessionState() constructor. But the PRStile variable initialization was added early in #13758. I updated the PR description. Thanks for pointing this!

@daxian-dbw daxian-dbw merged commit 48be7b7 into PowerShell:master Oct 28, 2021
@iSazonov iSazonov deleted the perf-init-psstyle branch October 29, 2021 02:51
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@iSazonov @TrapGodBrim
Avoid validation for built-in file extension and color VT sequences (P…
118808c 
…owerShell#16320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

@rjmholt rjmholt Awaiting requested review from rjmholt

Assignees

@daxian-dbw daxian-dbw

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iSazonov @daxian-dbw