Skip to content

Don't throw exception when trying to resolve a possible link path #16310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 6 commits into from
Oct 30, 2021
Merged

Don't throw exception when trying to resolve a possible link path #16310

adityapatwardhan merged 6 commits into from
Oct 30, 2021

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Oct 27, 2021 •
edited
Loading

PR Summary

Fix #16293
Before #16165, we were using InternalSymbolicLinkLinkCodeMethods.WinInternalGetTarget to try resolving a possible link path, and that API never throws -- catch exception and returns null. However, File.ResolveLinkTarget throws when there is any error while resolving the link path, e.g. the file system doesn't support reparse point. This caused a regression in 7.2.0-rc1.

The fix is to wrap File.ResolveLinkTarget in a try/catch block, and use the original fileName when ResolveLinkTarget fails.

@iSazonov and @jborean93, thank you both for bring the regression to our attention, and also worked out the test.

PR Checklist

@daxian-dbw daxian-dbw mentioned this pull request Oct 27, 2021
Closed
22 tasks
iSazonov
iSazonov approved these changes Oct 27, 2021
View reviewed changes
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Oct 27, 2021
@daxian-dbw @adityapatwardhan
Update test/powershell/Language/Scripting/NativeExecution/NativeComma…
85d3c4b 
…ndProcessor.Tests.ps1

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
@daxian-dbw @adityapatwardhan
Update test/powershell/Language/Scripting/NativeExecution/NativeComma…
6ef6570 
…ndProcessor.Tests.ps1

Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
@adityapatwardhan
Copy link
Member

adityapatwardhan commented Oct 30, 2021

@daxian-dbw New test is failing.. please have a look

@pull-request-quantifier-deprecated
Copy link

pull-request-quantifier-deprecated bot commented Oct 30, 2021

This PR has 37 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +34 -3
Percentile : 14.8%

Total files changed: 2

Change summary by file extension:
.cs : +5 -3
.ps1 : +29 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan merged commit 723a508 into PowerShell:master Oct 30, 2021
@daxian-dbw daxian-dbw deleted the regress branch October 30, 2021 16:36
@ghost
Copy link

ghost commented Nov 8, 2021

🎉v7.2.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Nov 8, 2021
Closed
5 tasks
t10-13rocket
t10-13rocket approved these changes Nov 12, 2021
View reviewed changes
Copy link

@t10-13rocket t10-13rocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov iSazonov mentioned this pull request Nov 30, 2021
Closed
@unfurl-links unfurl-links bot mentioned this pull request Dec 2, 2021
Closed
5 tasks
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@daxian-dbw @TrapGodBrim
Don't throw exception when trying to resolve a possible link path (Po…
054fd79 
…werShell#16310)
daxian-dbw added a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
@daxian-dbw @adityapatwardhan
Don't throw exception when trying to resolve a possible link path (Po…
9e5e8a2 
…werShell#16310)
@TravisEz13 TravisEz13 mentioned this pull request May 24, 2022
Merged
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
Merged
22 tasks
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@iSazonov iSazonov iSazonov approved these changes

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+2 more reviewers

@jborean93 jborean93 jborean93 approved these changes

@t10-13rocket t10-13rocket t10-13rocket approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adityapatwardhan adityapatwardhan

Labels

Backport-7.2.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

OperationStopped: Incorrect function when running an exe from a mounted ISO

5 participants

@daxian-dbw @adityapatwardhan @jborean93 @iSazonov @t10-13rocket