Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Oct 21, 2021

PR Summary

Create daily compliance build which:

  1. Creates a notice file and puts it in a blob (will use a GitHub workflow to update in master)
  2. moves policheck and credscan to this build

PR Context

PR Checklist

@ghost ghost assigned daxian-dbw Oct 21, 2021
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 22, 2021
Copy link
Collaborator

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual third party additional attributions code looks sound, just some comments on style and documentation (the latter I think is going to be important to maintain this)

@TravisEz13 TravisEz13 added MustHave Compliance Related to compliance requirements labels Oct 27, 2021
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please resolve the conflicts.

@TravisEz13 TravisEz13 force-pushed the create-compliance-build branch from 9403f65 to 5be65ec Compare October 28, 2021 00:35
@TravisEz13 TravisEz13 merged commit 5ce5936 into PowerShell:master Oct 28, 2021
@ghost
Copy link

ghost commented Dec 14, 2021

🎉v7.2.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
Co-authored-by: Robert Holt <rjmholt@gmail.com>
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Mar 9, 2022
Co-authored-by: Robert Holt <rjmholt@gmail.com>
@TravisEz13 TravisEz13 mentioned this pull request Jun 7, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Compliance Related to compliance requirements MustHave

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants