Removed unused docker-based tests for PS release packages #16224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmenaga
added
CL-CodeCleanup
anmenaga
requested review from
adityapatwardhan and
daxian-dbw
as code owners
ghost
assigned
iSazonov
added
CL-Test
TravisEz13
approved these changes
Oct 15, 2021
adityapatwardhan
added
BackPort-7.0.x-Approved
and removed
BackPort-7.0.x-Consider
labels
daxian-dbw
pushed a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Oct 21, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
Member
|
/backport to release/v7.0.11 |
Contributor
|
Started backporting to release/v7.0.11: https://github.com/PowerShell/PowerShell/actions/runs/2242762082
|
Contributor
|
@TravisEz13 backporting to release/v7.0.11 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Removed old not-used-anymore docker-based tests for PS release packages
Using index info to reconstruct a base tree...
M docker/tests/containerTestCommon.psm1
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): docker/tests/containerTestCommon.psm1 deleted in Removed old not-used-anymore docker-based tests for PS release packages and modified in HEAD. Version HEAD of docker/tests/containerTestCommon.psm1 left in tree.
Removing docker/tests/Templates/ubuntu18.04/Dockerfile
Removing docker/tests/Templates/ubuntu16.04/Dockerfile
Removing docker/tests/Templates/opensuse42.3/Dockerfile
Removing docker/tests/Templates/fxdependent-ubuntu18.04/Dockerfile
Removing docker/tests/Templates/fxdependent-ubuntu16.04/Dockerfile
Removing docker/tests/Templates/fxdependent-opensuse42.3/Dockerfile
Removing docker/tests/Templates/fxdependent-fedora28/Dockerfile
Removing docker/tests/Templates/fxdependent-dotnetsdk-latest/Dockerfile
Removing docker/tests/Templates/fxdependent-debian.9/Dockerfile
Removing docker/tests/Templates/fxdependent-centos7/Dockerfile
Removing docker/tests/Templates/fedora28/Dockerfile
Removing docker/tests/Templates/debian.9/Dockerfile
Removing docker/tests/Templates/centos7/Dockerfile
Removing docker/tests/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Removed old not-used-anymore docker-based tests for PS release packages
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
TravisEz13
pushed a commit
that referenced
this pull request
May 4, 2022
…es (#16224) # Conflicts: # docker/tests/containerTestCommon.psm1
|
🎉 Handy links: |
22 tasks
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
These are not used anymore and are causing alerts (e.g. for Ubuntu 16), so removing them.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).