Fix '-PipelineVariable' to set variable in the right scope #16199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iSazonov
reviewed
Oct 6, 2021
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
Have we the same issue for other variables like OutVariable?
Member
Author
|
No, only pipeline variable is special. |
iSazonov
reviewed
Oct 6, 2021
rjmholt
reviewed
Oct 6, 2021
rjmholt
approved these changes
Oct 6, 2021
iSazonov
reviewed
Oct 7, 2021
rjmholt
added
CL-Engine
15 tasks
|
🎉 Handy links: |
ghost
mentioned this pull request
5 tasks
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #16155
Fix '-PipelineVariable' to set variable in the right scope and to not remove the pipeline variable at the end of pipeline when it's actually using an already existing variable.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.