Move GetOuputString() and GetFormatStyleString() to PSHostUserInterface as public API
#16075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface as public APIs
rjmholt
reviewed
Sep 9, 2021
src/System.Management.Automation/engine/hostifaces/MshHostUserInterface.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
I'm going to make a change, for public hosts, some of the parameters don't make any sense. I'll have a simpler public version and keep the current one as internal. |
…be plaintext so that parameter is needed publicly
daxian-dbw
approved these changes
Sep 10, 2021
src/System.Management.Automation/engine/hostifaces/MshHostUserInterface.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/hostifaces/MshHostUserInterface.cs
Outdated
Show resolved
Hide resolved
daxian-dbw
added
the
CL-General
…Interface.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
…Interface.cs Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
TravisEz13
pushed a commit
that referenced
this pull request
Sep 29, 2021
…terface` as public API (#16075)
|
🎉 Handy links: |
ghost
mentioned this pull request
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
…terface` as public API (PowerShell#16075)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #14387
Follow up on #14397. These two APIs were previously internal and used by the ConsoleHost. However, this means that every host would need to have similar code to handle ANSI rendering correctly. Discussion with @daxian-dbw and @rjmholt was to move them to
PSHostUserInterfaceso they can be used by the dotnet-interactive Jupyter kernel and the vscode-powershell extension.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).