Don't use ArgumentList when creating COM object as it's not applicable to the COM parameter set
#15915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to the COM parameter set
ghost
assigned
rjmholt
approved these changes
Aug 12, 2021
adityapatwardhan
approved these changes
Aug 12, 2021
iSazonov
added
the
CL-General
xtqqczze
pushed a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Aug 20, 2021
…ble to the COM parameter set (PowerShell#15915)
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
We ran into a .NET bug in .NET 6 preview.7 when creating a COM object with
Activator.CreateInstance. The bug is triggered when passing an empty arguments array along with the COM type toCreateInstance(see the bug here). The workaround is to not passing in the empty argument array.When looking at our
New-Objectcode with @adityapatwardhan, we found-ArgumentListis not even in theCOMparameter set, but the COM object creation code is still usingArgumentList. That's not right and is fixed in this PR.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.