Update .NET adapter to handle interface static members properly #15908
Conversation
ghost
assigned
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
Interesting, could we benefit from a source generator to pre-build the cache at compile time or this will force to load extra assemblies at startup?
|
@daxian-dbw Please respond to Rob's comments. |
|
All comments are addressed. Please take another look, thanks! |
|
Its worth calling out that, aside from I would have expected that such members were at least not preferred over matching public members (even once powershell can properly support |
|
A basic breaking-change issue documenting this has been created here: https://github.com/dotnet/runtime/issues/57323 |
adityapatwardhan
added
the
CL-Engine
|
🎉 Handy links: |
|
🎉 Handy links: |
6 participants
PR Summary
After switching to the latest dotnet 6 preview.7 SDK, we started to see the "Bad IL format" failure as shown below (see the reported dotnet bug here).
This is because a new preview feature is enabled in preview.7, which allows an interface to have abstract static methods (see the blog post). The type
System.Int16implements much more interfaces in preview.7, and many of them declare abstract static properties. However, the abstract static properties cannot be invoked withGetValue(null)reflection API, and doing so results in thisBad IL formaterror.The recommendation from .NET team is to ignore static virtual/abstract members on an interface, especially as the set of APIs may change with .NET 7.
This PR includes the following changes:
DisablePrivateReflectionAttributeis already obsolete and there is no restriction on private reflection in .NET Core, removeDisallowPrivateReflectionand uses of it from our code.PopulateMethodReflectionTablehandles interface was to calltype.GetInterfaceMap(interfaceType)and use the interface methods from the returned mapping object. The static non-virtual methods on an interface will be missed in this way, so, this is changed to callinterfaceType.GetMethods(bindingFlags)directly.MethodCacheEntryconstructor, to avoid unneeded array creation.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.