Skip to content

Conversation

@rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Aug 9, 2021

PR Summary

Continuation of @rkeithhill's work in #15757.

Implements error throwing with error action preference integration for native executables, similar to set -e scenarios on *nix.

PR Context

See on PowerShell/PowerShell-RFC#277.

PR Checklist

@rjmholt rjmholt requested a review from daxian-dbw August 23, 2021 20:01
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 23, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 24, 2021
@rjmholt rjmholt requested a review from daxian-dbw August 24, 2021 00:28
continue
}

$hitTrap = $false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we explicitly create $exception in the scope too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it'll be $null by default, rather than $false, so we don't really need to

@daxian-dbw daxian-dbw merged commit a4d1457 into PowerShell:master Aug 24, 2021
@rjmholt rjmholt deleted the nativeerror-addressfeedback branch September 2, 2021 17:02
xtqqczze pushed a commit to xtqqczze/PowerShell-PowerShell that referenced this pull request Sep 2, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants