Skip to content

Add more information when a syslog parsing error occurs - #15857

Merged
Rob Holt (rjmholt) merged 3 commits into
PowerShell:masterfrom
JamesWTruher:SyslogTest002
Aug 4, 2021
Merged

Rob Holt (rjmholt) merged 3 commits into
PowerShell:masterfrom
JamesWTruher:SyslogTest002

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Aug 2, 2021 •

Copy link
Copy Markdown
Collaborator

PR Summary

still no repro outside of our nightly builds.
I have hardened the code a bit more and added additional debugging output in case other exceptions are generated.
It appears that the syslog file contains data that the helper module cannot deal with, so I've added additional output to help understand what that data looks like.

PR Context

we are having a build breaking test failure which has been difficult to reproduce.

PR Checklist

@JamesWTruher James Truher (JamesWTruher) changed the title WIP: Add more information when a parsing error occurs Add more information when a syslog parsing error occurs Aug 3, 2021
@rjmholt Rob Holt (rjmholt) self-assigned this Aug 4, 2021
@rjmholt
Rob Holt (rjmholt) marked this pull request as ready for review August 4, 2021 17:19
@rjmholt
Rob Holt (rjmholt) enabled auto-merge (squash) August 4, 2021 17:20
@iSazonov Ilya (iSazonov) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Aug 4, 2021
@rjmholt
Rob Holt (rjmholt) merged commit 5fea4c3 into PowerShell:master Aug 4, 2021
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

@JamesWTruher
James Truher (JamesWTruher) deleted the SyslogTest002 branch September 23, 2023 05:36
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants