Skip to content

Harden logic when looking for syslog entries for failing test #15841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jul 30, 2021
Merged

Harden logic when looking for syslog entries for failing test #15841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions test/powershell/Host/Logging.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,15 @@ $PID

It 'Verifies logging level filtering works' -Skip:(!$IsSupportedEnvironment) {
$configFile = WriteLogSettings -LogId $logId -LogLevel Warning
& $powershell -NoProfile -SettingsFile $configFile -Command '$env:PSModulePath | out-null'
$result = & $powershell -NoProfile -SettingsFile $configFile -Command '$PID'
$result | Should -Not -BeNullOrEmpty

# by default, PowerShell only logs informational events on startup. With Level = Warning, nothing should
# have been logged.
$items = Get-PSSysLog -Path $SyslogFile -Id $logId -Tail 100 -TotalCount 1
$items | Should -Be $null
# have been logged. We'll collect all the syslog entries and look for $PID (there should be none).
$items = Get-PSSysLog -Path $SyslogFile
@($items).Count | Should -BeGreaterThan 0
$logs = $items | Where-Object { $_.ProcessId -eq $result }
$logs | Should -BeNullOrEmpty
Comment on lines +256 to +259
Copy link
Collaborator

@rjmholt rjmholt Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the test previously assumed there would be no entries, but now we expect some entries but none with the PID data. What's changed?

Copy link
Member

@adityapatwardhan adityapatwardhan Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was added to make it more robust.

}
}

Expand Down