Skip to content

Fix CA1052 in TypeCatalogGen - #15840

Merged
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
xtqqczze:CA1052-p3
Aug 5, 2021
Merged

Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
xtqqczze:CA1052-p3

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

In #15775, we missed a warning as TreatWarningsAsErrors was not enabled.

Again, possible breaking public API change (Unlikely Grey Area), however instantiating the class has no obvious utility and furthermore the API doesn't appear to be publicly documented.

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 29, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Aug 5, 2021
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13

Copy link
Copy Markdown
Member

This is a tool not part of PowerShell, so not a breaking change

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 5, 2021
@TravisEz13 Travis Plunk (TravisEz13) changed the title Fix CA1052 in TypeCatalogGen Fix CA1052 in TypeCatalogGen Aug 5, 2021
@TravisEz13
Travis Plunk (TravisEz13) merged commit 44595a4 into PowerShell:master Aug 5, 2021
@xtqqczze
xtqqczze deleted the CA1052-p3 branch August 6, 2021 02:27
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants