Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Jul 21, 2021

PR Summary

This change updates that Version member of ServerRemoteHost to be exactly $PSVersionTable.PSVersion instead of a fixed 1.0.0.0.

PR Context

ServerRemoteHost which is used when using PowerShell remoting has a fixed version of 1.0.0.0. This doesn't really provide any information when retrieved via $Host.Version. Instead, it should reflect the version of PowerShell being used.

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from PaulHigin July 21, 2021 00:01
@ghost ghost assigned TravisEz13 Jul 21, 2021
@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 21, 2021
@SteveL-MSFT
Copy link
Member Author

@PaulHigin I searched the Windows code base and browsed a few pages of GitHub hits and it seems that there is code checking for ServerRemoteHost, but not the version. So I think this is a safe change as it doesn't seem like anyone is depending on it being 1.0.0.0

@TravisEz13
Copy link
Member

@SteveL-MSFT Do we want to mark this for backport?

@SteveL-MSFT
Copy link
Member Author

@TravisEz13 no, there's no need to backport this

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 4, 2021
@ghost
Copy link

ghost commented Aug 4, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov
Copy link
Collaborator

iSazonov commented Aug 4, 2021

@TravisEz13 Ready to merge?

@ghost ghost removed the Review - Needed The PR is being reviewed label Aug 4, 2021
@TravisEz13 TravisEz13 changed the title Update ServerRemoteHost Version to be same as PSVersion Update ServerRemoteHost Version to be same as PSVersion Aug 4, 2021
@TravisEz13 TravisEz13 merged commit 2ae0e4d into PowerShell:master Aug 4, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.9 milestone Aug 5, 2021
@SteveL-MSFT SteveL-MSFT deleted the serverremotehost-version branch August 16, 2021 21:28
@ghost
Copy link

ghost commented Aug 23, 2021

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Sep 28, 2021

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants