Skip to content

Fix IDisposable implementation in CommandPathSearch #15793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jul 20, 2021
Merged

Fix IDisposable implementation in CommandPathSearch #15793

iSazonov merged 1 commit into from
Jul 20, 2021

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 18, 2021 •
edited
Loading

Fix CA2213: Disposable fields should be disposed in System.Management.Automation.CommandPathSearch.

@xtqqczze
Fix IDisposable impl for CommandPathSearch
66c4c24 
Fix IDisposable implementation for `System.Management.Automation.CommandPathSearch`
@xtqqczze xtqqczze changed the title Fix IDisposable impl for CommandPathSearch Fix IDisposable implementation in CommandPathSearch Jul 18, 2021
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 18, 2021

CodeFactor "complex method" issues are false positives, see #15721.

@iSazonov
Copy link
Collaborator

iSazonov commented Jul 19, 2021

Can we enable the rule explicitly?

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 19, 2021

Can we enable the rule explicitly?

We can enable CA2213 as suggestion, but it will be noisy, as there are many violations.

@iSazonov iSazonov merged commit 71f62c7 into PowerShell:master Jul 20, 2021
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 20, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jul 20, 2021
@iSazonov
Copy link
Collaborator

iSazonov commented Jul 20, 2021

Can we enable the rule explicitly?

We can enable CA2213 as suggestion, but it will be noisy, as there are many violations.

This raises concerns.

@xtqqczze xtqqczze deleted the idisposable-CommandPathSearch branch July 20, 2021 12:43
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 20, 2021

Can we enable the rule explicitly?

We can enable CA2213 as suggestion, but it will be noisy, as there are many violations.

This raises concerns.

Issue opened: #15803.

@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @adityapatwardhan