Skip to content

Implement IDisposable for ConvertToJsonCommand #15787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 4 commits into from
Jul 20, 2021
Merged

Implement IDisposable for ConvertToJsonCommand #15787

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca21c61
Implement `IDisposable`
xtqqczze Jul 16, 2021
f3fad43
Minor update
daxian-dbw Jul 16, 2021
29cdfb4
Minor update - 2
daxian-dbw Jul 16, 2021
83a452f
Remove `_disposed` bool
xtqqczze Jul 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/ConvertToJsonCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Microsoft.PowerShell.Commands
/// This command converts an object to a Json string representation.
/// </summary>
[Cmdlet(VerbsData.ConvertTo, "Json", HelpUri = "https://go.microsoft.com/fwlink/?LinkID=2096925", RemotingCapability = RemotingCapability.None)]
public class ConvertToJsonCommand : PSCmdlet
public class ConvertToJsonCommand : PSCmdlet, IDisposable
{
/// <summary>
/// Gets or sets the InputObject property.
Expand Down Expand Up @@ -77,6 +77,29 @@ public int Depth
[Parameter]
public StringEscapeHandling EscapeHandling { get; set; } = StringEscapeHandling.Default;

/// <summary>
/// IDisposable implementation, dispose of any disposable resources created by the cmdlet.
/// </summary>
public void Dispose()
{
Dispose(disposing: true);
GC.SuppressFinalize(this);
}

/// <summary>
/// Implementation of IDisposable for both manual Dispose() and finalizer-called disposal of resources.
/// </summary>
/// <param name="disposing">
/// Specified as true when Dispose() was called, false if this is called from the finalizer.
/// </param>
protected virtual void Dispose(bool disposing)
{
if (disposing)
{
_cancellationSource.Dispose();
}
}

/// <summary>
/// Prerequisite checks.
/// </summary>
Expand Down