Skip to content

Specify api_surface property for all code quality rules #15778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jul 23, 2021
Merged

Specify api_surface property for all code quality rules #15778

iSazonov merged 1 commit into from
Jul 23, 2021

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 14, 2021

@ghost ghost assigned TravisEz13 Jul 14, 2021
@iSazonov
Copy link
Collaborator

iSazonov commented Jul 15, 2021

Why do we need this? The default is already public.

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 15, 2021

Why do we need this? The default is already public.

It makes the configuration explicit.

For CA1801 and CA2208 the default api_surface is all.

@iSazonov
Copy link
Collaborator

iSazonov commented Jul 15, 2021

For CA1801 and CA2208 the default api_surface is all.

All the more reason not to change the default value

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 15, 2021

For CA1801 and CA2208 the default api_surface is all.

All the more reason not to change the default value

This PR doesn't change the default value for any analyzer.

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 23, 2021
@ghost
Copy link

ghost commented Jul 23, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 23, 2021
@iSazonov iSazonov assigned iSazonov and unassigned TravisEz13 Jul 23, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 23, 2021
@iSazonov iSazonov merged commit 6a21bcc into PowerShell:master Jul 23, 2021
@xtqqczze xtqqczze deleted the analyzers-api_surface branch July 24, 2021 00:01
@ghost
Copy link

ghost commented Aug 23, 2021

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Sep 28, 2021

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @TravisEz13