Skip to content

Specify api_surface property for all code quality rules - #15778

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:analyzers-api_surface
Jul 23, 2021
Merged

Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:analyzers-api_surface

Conversation

@xtqqczze

Copy link
Copy Markdown
Contributor

@iSazonov

Copy link
Copy Markdown
Collaborator

Why do we need this? The default is already public.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Why do we need this? The default is already public.

It makes the configuration explicit.

For CA1801 and CA2208 the default api_surface is all.

@iSazonov

Copy link
Copy Markdown
Collaborator

For CA1801 and CA2208 the default api_surface is all.

All the more reason not to change the default value

@xtqqczze

Copy link
Copy Markdown
Contributor Author

For CA1801 and CA2208 the default api_surface is all.

All the more reason not to change the default value

This PR doesn't change the default value for any analyzer.

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 23, 2021
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 23, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 23, 2021
@iSazonov
Ilya (iSazonov) merged commit 6a21bcc into PowerShell:master Jul 23, 2021
@xtqqczze
xtqqczze deleted the analyzers-api_surface branch July 24, 2021 00:01
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.9 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.10 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj-contribs/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants