Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Jul 14, 2021

PR Summary

The warning now only appears when the first opt-in is checked and not the second.

2021-07-15_13-48-18 (1)

PR Context

Make the warning in #15727 dynamic

PR Checklist

@ghost ghost assigned rjmholt Jul 14, 2021
@TravisEz13 TravisEz13 mentioned this pull request Jul 14, 2021
22 tasks
@TravisEz13 TravisEz13 force-pushed the mu-opt-out-dynamic branch from 96318a8 to b2529a7 Compare July 15, 2021 00:51
@TravisEz13 TravisEz13 force-pushed the mu-opt-out-dynamic branch from 348f88c to 22316ac Compare July 15, 2021 17:13
@TravisEz13 TravisEz13 changed the title Mu opt out dynamic Make waring about MU being required most of the time dynamic Jul 15, 2021
@TravisEz13 TravisEz13 marked this pull request as ready for review July 15, 2021 20:54
Copy link
Contributor

@joeyaiello joeyaiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the GIF, looks great. May be worth running through a screen reader to see if the hidden text gets read (while it's invisible, or at all) since we usually get dinged for that with accessibility folks.

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jul 15, 2021
@rjmholt rjmholt changed the title Make waring about MU being required most of the time dynamic Make warning about MU being required most of the time dynamic Jul 20, 2021
@rjmholt rjmholt merged commit 074f091 into PowerShell:master Jul 20, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.8 milestone Jul 20, 2021
@TravisEz13 TravisEz13 deleted the mu-opt-out-dynamic branch July 21, 2021 18:45
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants