-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Make warning about MU being required most of the time dynamic #15776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
96318a8 to
b2529a7
Compare
348f88c to
22316ac
Compare
joeyaiello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the GIF, looks great. May be worth running through a screen reader to see if the hidden text gets read (while it's invisible, or at all) since we usually get dinged for that with accessibility folks.
|
🎉 Handy links: |
PR Summary
The warning now only appears when the first opt-in is checked and not the second.
PR Context
Make the warning in #15727 dynamic
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).