Skip to content

Conversation

@adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Jul 13, 2021

PR Summary

PR Context

Update to use crossgen2 instead of crossgen

PR Checklist

@ghost ghost assigned rjmholt Jul 13, 2021
@adityapatwardhan adityapatwardhan force-pushed the UseCrossGen2 branch 3 times, most recently from 050a33f to 1bcf519 Compare July 14, 2021 17:59
@adityapatwardhan adityapatwardhan changed the title Update to use crossgen2 Update to .NET 6 Preview 6 and use crossgen2 Jul 19, 2021
@adityapatwardhan adityapatwardhan marked this pull request as ready for review July 19, 2021 20:18
} elseif ($Runtime -eq "linux-x64") {
$Runtime
# We should set $generateSymbols = $true, but the code needs to be adjusted for different extension on Linux
"win-x64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment

# instead of returning a PacketTooBig response cleanly.
It "MTUSizeDetect works" -Pending:($env:__INCONTAINER -eq 1) {
# Test disabled due to .NET runtime issue: https://github.com/dotnet/runtime/issues/55961
It "MTUSizeDetect works" -Pending:(($env:__INCONTAINER -eq 1) -or $true) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable only for macOS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 19, 2021
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments to be addressed

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 19, 2021
@adityapatwardhan adityapatwardhan merged commit 31a4528 into PowerShell:master Jul 19, 2021
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jul 19, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.8 milestone Jul 19, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants