-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update to .NET 6 Preview 6 and use crossgen2 #15763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to .NET 6 Preview 6 and use crossgen2 #15763
Conversation
050a33f to
1bcf519
Compare
13f6adb to
7d941f6
Compare
| } elseif ($Runtime -eq "linux-x64") { | ||
| $Runtime | ||
| # We should set $generateSymbols = $true, but the code needs to be adjusted for different extension on Linux | ||
| "win-x64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment
| # instead of returning a PacketTooBig response cleanly. | ||
| It "MTUSizeDetect works" -Pending:($env:__INCONTAINER -eq 1) { | ||
| # Test disabled due to .NET runtime issue: https://github.com/dotnet/runtime/issues/55961 | ||
| It "MTUSizeDetect works" -Pending:(($env:__INCONTAINER -eq 1) -or $true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable only for macOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
TravisEz13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
TravisEz13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments to be addressed
|
🎉 Handy links: |
PR Summary
System.IO.FileSystem.dllas it is not loaded anymore.PR Context
Update to use crossgen2 instead of crossgen
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).