Skip to content

Conversation

@adityapatwardhan
Copy link
Member

PR Summary

  • Add more logging when generating csproj for reference assembly generation
  • Make sure the SHA512SUMS file is written at the end of hash computation as it is written at the same location which is looped through.

PR Context

Fix daily build break.

PR Checklist

@ghost ghost assigned rjmholt Jul 7, 2021
@adityapatwardhan adityapatwardhan marked this pull request as ready for review July 7, 2021 17:11
Co-authored-by: Robert Holt <rjmholt@gmail.com>
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jul 7, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.8 milestone Jul 7, 2021
@ghost ghost removed this from the 7.2.0-preview.8 milestone Jul 7, 2021
@ghost
Copy link

ghost commented Jul 7, 2021

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.8 milestone Jul 7, 2021
@ghost ghost removed this from the 7.2.0-preview.8 milestone Jul 7, 2021
@ghost
Copy link

ghost commented Jul 7, 2021

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@adityapatwardhan adityapatwardhan merged commit 03c0933 into PowerShell:master Jul 7, 2021
@adityapatwardhan adityapatwardhan deleted the FixBuildNuget branch July 7, 2021 20:17
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.8 milestone Jul 7, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants