Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 6, 2021

Search and replace private class -> private sealed class.

Contributes to #15110.

@ghost ghost assigned rjmholt Jul 6, 2021
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 6, 2021

CodeFactor new "complex method" issues are false positives, see #15721.

@xtqqczze xtqqczze changed the title WIP: Seal private classes Seal private classes Jul 6, 2021
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 10, 2021
@xtqqczze xtqqczze marked this pull request as ready for review July 13, 2021 14:04
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 13, 2021
@xtqqczze xtqqczze closed this Jul 13, 2021
@xtqqczze xtqqczze reopened this Jul 13, 2021
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 13, 2021
@iSazonov iSazonov merged commit 883ca98 into PowerShell:master Jul 19, 2021
@iSazonov iSazonov assigned iSazonov and unassigned rjmholt Jul 19, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jul 19, 2021
@xtqqczze xtqqczze deleted the sealed-private branch July 19, 2021 13:45
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants