Skip to content

WIP: Don't specify paramName for ArgumentNullException in properties #15720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xtqqczze wants to merge 2 commits into from
Closed

WIP: Don't specify paramName for ArgumentNullException in properties #15720

xtqqczze wants to merge 2 commits into from

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 5, 2021 •
edited
Loading

Specifying value as a paramName for ArgumentException in properties does not add any value over the stack trace.

Follow-up to #15604 (comment).

@ghost ghost assigned adityapatwardhan Jul 5, 2021
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 5, 2021 •
edited
Loading

CodeFactor "complex method" new issues are false positives, issue opened: #15721.

@iSazonov
Copy link
Collaborator

iSazonov commented Jul 5, 2021

@xtqqczze Please add more information in the PR description for reviewers why we need the changes..

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 5, 2021 •
edited
Loading

However, Framework Design Guidelines (2008) from Addison-Wesley Microsoft Technology Series recommend this pattern:

DO use value for the name of the implicit value parameter of property setters.

https://docs.microsoft.com/dotnet/standard/design-guidelines/using-standard-exception-types#argumentexception-argumentnullexception-and-argumentoutofrangeexception

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 5, 2021 •
edited
Loading

Removing the paramName would also violate CA2208: Instantiate argument exceptions correctly.

Issue opened: dotnet/roslyn-analyzers#5209.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 9, 2021
@xtqqczze xtqqczze changed the title Don't specify paramName for ArgumentNullException in properties WIP: Don't specify paramName for ArgumentNullException in properties Jul 13, 2021
@ghost ghost added the Stale label Jul 28, 2021
@ghost
Copy link

ghost commented Jul 28, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost closed this Aug 8, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw will be requested when the pull request is marked ready for review daxian-dbw is a code owner

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13 TravisEz13 will be requested when the pull request is marked ready for review TravisEz13 is a code owner

Assignees

@adityapatwardhan adityapatwardhan

Labels

Stale Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @adityapatwardhan