Skip to content

Enable IDE0070: UseSystemHashCode #15715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jul 14, 2021
Merged

Enable IDE0070: UseSystemHashCode #15715

iSazonov merged 1 commit into from
Jul 14, 2021

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jul 3, 2021

Enable IDE0070: UseSystemHashCode as warning.

@ghost ghost assigned iSazonov Jul 3, 2021
@xtqqczze xtqqczze marked this pull request as ready for review July 3, 2021 05:40
@iSazonov
Copy link
Collaborator

iSazonov commented Jul 4, 2021

I wonder we get no warnings.

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 4, 2021
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jul 5, 2021 •
edited by unfurl-links bot
Loading

https://github.com/dotnet/roslyn/blob/315c2e149ba7889b0937d872274c33fcbfe9af5f/src/Analyzers/CSharp/Tests/UseSystemHashCode/UseSystemHashCodeTests.cs

GitHub
The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs. - dotnet/roslyn

@ghost ghost added the Review - Needed The PR is being reviewed label Jul 13, 2021
@ghost
Copy link

ghost commented Jul 13, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov iSazonov merged commit ad87f9c into PowerShell:master Jul 14, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jul 14, 2021
@iSazonov iSazonov added this to the 7.2.0-preview.8 milestone Jul 14, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.8

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov