Skip to content

Enable CA1812: Avoid uninstantiated internal classes #15674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 1 commit into from
Jun 27, 2021
Merged

Enable CA1812: Avoid uninstantiated internal classes #15674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ dotnet_diagnostic.CA1810.severity = none

# CA1812: Avoid uninstantiated internal classes
# https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1812
dotnet_diagnostic.CA1812.severity = none
dotnet_diagnostic.CA1812.severity = warning

# CA1813: Avoid unsealed attributes
# https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1813
Expand Down
5 changes: 5 additions & 0 deletions src/Microsoft.PowerShell.Commands.Utility/commands/utility/Join-String.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System;
using System.Collections;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.Linq;
using System.Management.Automation;
Expand Down Expand Up @@ -159,6 +160,10 @@ protected override void EndProcessing()
}
}

[SuppressMessage(
"Microsoft.Performance",
"CA1812:AvoidUninstantiatedInternalClasses",
Justification = "Class is instantiated through late-bound reflection")]
internal class JoinItemCompleter : IArgumentCompleter
{
public IEnumerable<CompletionResult> CompleteArgument(
Expand Down