Skip to content

Enable CA1812: Avoid uninstantiated internal classes #15674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 1 commit into from
Jun 27, 2021
Merged

Enable CA1812: Avoid uninstantiated internal classes #15674

iSazonov merged 1 commit into from
Jun 27, 2021

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jun 25, 2021

Enable CA1812: Avoid uninstantiated internal classes

Add suppression for classes instantiated with System.Activator.CreateInstance.

@ghost ghost assigned iSazonov Jun 25, 2021
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 25, 2021 

D:\a\1\s\src\Microsoft.Management.UI.Internal\commandHelpers\OutGridView.cs(21,20): error CA1812: OutGridViewWindow is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it static (Shared in Visual Basic). [D:\a\1\s\src\Microsoft.Management.UI.Internal\Microsoft.PowerShell.GraphicalHost_j30bp2hs_wpftmp.csproj]
D:\a\1\s\src\Microsoft.Management.UI.Internal\ManagementList\Common\WeakEventListener.cs(13,20): error CA1812: WeakEventListener<TEventArgs> is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it static (Shared in Visual Basic). [D:\a\1\s\src\Microsoft.Management.UI.Internal\Microsoft.PowerShell.GraphicalHost_j30bp2hs_wpftmp.csproj]
D:\a\1\s\src\Microsoft.Management.UI.Internal\commandHelpers\ShowCommandHelper.cs(26,20): error CA1812: ShowCommandHelper is an internal class that is apparently never instantiated. If so, remove the code from the assembly. If this class is intended to contain only static members, make it static (Shared in Visual Basic). [D:\a\1\s\src\Microsoft.Management.UI.Internal\Microsoft.PowerShell.GraphicalHost_j30bp2hs_wpftmp.csproj]

I thought we had suppressed analyzers in Microsoft.Management.UI.Internal, now this is ineffective?

PowerShell/src/Microsoft.Management.UI.Internal/.globalconfig

Lines 1 to 3 in 756aef9

is_global = true
dotnet_analyzer_diagnostic.severity = none

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Jun 25, 2021 •
edited
Loading

The Microsoft.Management.UI.Internal analyzers issue is resolved in #15677 by setting RunAnalyzers to false in Microsoft.PowerShell.GraphicalHost.csproj.

@xtqqczze xtqqczze closed this Jun 25, 2021
@xtqqczze xtqqczze reopened this Jun 26, 2021
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 27, 2021
@iSazonov iSazonov merged commit b77bbf8 into PowerShell:master Jun 27, 2021
@xtqqczze xtqqczze deleted the CA1812 branch June 27, 2021 16:05
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

Assignees

@iSazonov iSazonov

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze @iSazonov