Skip to content

Make StringUtil classes static #15671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xtqqczze wants to merge 1 commit into from
Closed

Make StringUtil classes static #15671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/Microsoft.PowerShell.LocalAccounts/LocalAccounts/StringUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,8 @@ namespace System.Management.Automation.SecurityAccountsManager
/// <summary>
/// Contains utility functions for formatting localizable strings.
/// </summary>
internal class StringUtil
internal static class StringUtil
{
/// <summary>
/// Private constructor to precent auto-generation of a default constructor with greater accessability.
/// </summary>
private StringUtil()
{
}

[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1811:AvoidUncalledPrivateCode")]
internal static string Format(string str)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.ScheduledJob/ScheduledJobDefinition.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2300,7 +2300,7 @@ internal string FQEID
/// <summary>
/// Simple string formatting helper.
/// </summary>
internal class StringUtil
internal static class StringUtil
Copy link
Member

@daxian-dbw daxian-dbw Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScheduledJob module is not being built in the code base today, so please undo the change here.
Actually, we may need to think about remove the code that is not used today.

Copy link
Collaborator

@iSazonov iSazonov Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-) LocalAccounts/StringUtil.cs too.

Copy link
Contributor Author

@xtqqczze xtqqczze Jul 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daxian-dbw I guess work to remove uncompiled code is covered by #9960?

{
internal static string Format(string formatSpec, object o)
{
Expand Down