Skip to content

Fix CA2243: Attribute string literals should parse correctly #15622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Jun 25, 2021
Merged

Fix CA2243: Attribute string literals should parse correctly #15622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62ad4a4
Add missing `Remove-Alias` HelpUri
xtqqczze Jun 20, 2021
caf72a7
Enable CA2243: Attribute string literals should parse correctly
xtqqczze Jun 20, 2021
6d147e5
Update V2Cmdlets.csv
xtqqczze Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ dotnet_diagnostic.CA2242.severity = suggestion

# CA2243: Attribute string literals should parse correctly
# https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2243
dotnet_diagnostic.CA2243.severity = none
dotnet_diagnostic.CA2243.severity = warning

# CA2244: Do not duplicate indexed element initializations
# https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2244
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.PowerShell.Commands.Utility/commands/utility/RemoveAliasCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace Microsoft.PowerShell.Commands
/// <summary>
/// The implementation of the "Remove-Alias" cmdlet.
/// </summary>
[Cmdlet(VerbsCommon.Remove, "Alias", DefaultParameterSetName = "Default", HelpUri = "")]
[Cmdlet(VerbsCommon.Remove, "Alias", DefaultParameterSetName = "Default", HelpUri = "https://go.microsoft.com/fwlink/?linkid=2097127")]
[Alias("ral")]
public class RemoveAliasCommand : PSCmdlet
{
Expand Down
1 change: 1 addition & 0 deletions test/powershell/engine/Help/assets/HelpURI/V2Cmdlets.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ Register-EngineEvent,https://go.microsoft.com/fwlink/?linkid=2097128
Register-ObjectEvent,https://go.microsoft.com/fwlink/?linkid=2096714
Register-PSSessionConfiguration,https://go.microsoft.com/fwlink/?linkid=2096793
Register-WmiEvent,https://go.microsoft.com/fwlink/?LinkID=135245
Remove-Alias,https://go.microsoft.com/fwlink/?linkid=2097127
Remove-Computer,https://go.microsoft.com/fwlink/?LinkID=135246
Remove-Event,https://go.microsoft.com/fwlink/?linkid=2096715
Remove-EventLog,https://go.microsoft.com/fwlink/?LinkID=135248
Expand Down