Skip to content

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Jun 20, 2021

@ghost ghost assigned rjmholt Jun 20, 2021
@xtqqczze xtqqczze marked this pull request as ready for review June 20, 2021 21:04
@iSazonov
Copy link
Collaborator

/azp list

@iSazonov
Copy link
Collaborator

/azp run PowerShell-CI-windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xtqqczze xtqqczze marked this pull request as draft June 21, 2021 13:09
@xtqqczze xtqqczze force-pushed the update-globalconfig branch 2 times, most recently from 9b1f814 to ddea773 Compare June 21, 2021 13:52
@xtqqczze xtqqczze force-pushed the update-globalconfig branch from ddea773 to 0362cda Compare June 21, 2021 14:13
xtqqczze added 18 commits June 21, 2021 15:28
Enable [IL3002: Using member with RequiresAssemblyFilesAttribute can break functionality when embedded in a single-file app](https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/il3002)
Enable [CA1844: Provide memory-based overrides of async methods when subclassing 'Stream']((https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1844)
@xtqqczze xtqqczze force-pushed the update-globalconfig branch from 0362cda to 5032db3 Compare June 21, 2021 14:50
@xtqqczze xtqqczze marked this pull request as ready for review June 21, 2021 16:07
@xtqqczze
Copy link
Contributor Author

PowerShell-CI-macos failure appears unrelated: WebListener did not start before the timeout was reached.

@rjmholt
Copy link
Collaborator

rjmholt commented Jun 21, 2021

/azp run PowerShell-CI-macos

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rjmholt rjmholt added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 23, 2021
@rjmholt rjmholt merged commit 1f2dc26 into PowerShell:master Jun 23, 2021
@xtqqczze xtqqczze deleted the update-globalconfig branch June 23, 2021 22:00
@ghost
Copy link

ghost commented Jul 22, 2021

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new analyzer rules

3 participants