Skip to content

Conversation

@daxian-dbw
Copy link
Member

PR Summary

Update the mdspell command to ignore the test/perf folder.

PR Checklist

@rjmholt
Copy link
Collaborator

rjmholt commented Jun 14, 2021

Isn't that folder just ordinary markdown in our repo? Why does it need to be excluded?

@daxian-dbw
Copy link
Member Author

That folder contains files copied from dotnet/performance, including the markdown files, and we will have to sync with dotnet/performance from time to time.

@rjmholt
Copy link
Collaborator

rjmholt commented Jun 14, 2021

@daxian-dbw might be worth adding that as a comment above the invocation so we know why we have that specific exclusion

@daxian-dbw
Copy link
Member Author

daxian-dbw commented Jun 15, 2021

Narrow down the excluded folder to just dotnet-tools and add a comment to explain why.

@daxian-dbw daxian-dbw merged commit 6833b2a into PowerShell:master Jun 15, 2021
@daxian-dbw daxian-dbw deleted the mdspell branch June 15, 2021 20:31
@daxian-dbw daxian-dbw added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jun 15, 2021
@daxian-dbw daxian-dbw added this to the 7.2.0-preview.7 milestone Jun 15, 2021
@ghost
Copy link

ghost commented Jun 17, 2021

🎉v7.2.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants