Skip to content

Conversation

@iSazonov
Copy link
Collaborator

PR Summary

Tracking issue: #12631.

Replace #14189

We never check for null in the WriteDebug() API until low level host implementations where we ignore null messages.
For WriteError() we throw if null.
For WriteObject() we accept null.
For WriteProgress() we throw if null.
For WriteVerbose we accept null (we do the same as for WriteDebug()).
For WriteWarning we accept null (we do the same as for WriteDebug()).
For WriteCommandDetail() we accept null.

For ShouldProcess and ShouldContinue - it is all about formatting output and .Net format methods accepts nulls.

PR Context

PR Checklist

@iSazonov iSazonov requested a review from rjmholt June 12, 2021 07:36
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 12, 2021
@rjmholt rjmholt merged commit f570029 into PowerShell:master Jun 14, 2021
@iSazonov iSazonov deleted the nullable-icommandruntime branch June 14, 2021 18:18
@ghost
Copy link

ghost commented Jun 17, 2021

🎉v7.2.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants