Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Jun 10, 2021

PR Summary

Make sure GA revision increases from RC/Preview releases

  • Fix revision to 500 for all GA releases
  • Add tests to verify expected revisions

PR Context

Make sure GA revision increases from RC/Preview releases.
This allows SDK builds using preview to work against GA builds.

PR Checklist

@ghost ghost assigned iSazonov Jun 10, 2021
@TravisEz13 TravisEz13 marked this pull request as ready for review June 10, 2021 18:25
@adityapatwardhan
Copy link
Member

@TravisEz13 The nuget packages use the release tag to set the version for the package. Also, it is used to set the version of the ref assembly. That needs to be fixed too. Is that change happening in a different PR?

@TravisEz13
Copy link
Member Author

@adityapatwardhan The NuGet package needs to start using the runtime DLL, per yesterday's conversation. If we don't go down that path, I think the right thing to do is to read the fileversion from the runtime and use that.

Copy link

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For PR that only scoped to versioning numbers update - LGTM.

@adityapatwardhan
Copy link
Member

@TravisEz13 are you adding the change we discussed about the nuget ref assembly using the file version?

@adityapatwardhan
Copy link
Member

@TravisEz13 and me also discussed about using the runtime assembly for the ref, but there are some complications regarding it.

  1. Which runtime assembly do we use, windows or linux?
  2. Should the assemblies just be under lib folder? But, I believe lib does not support having RID under it.
  3. Can we just have runtime folder? Will the appropriate assembly be picked for compilation?

@daxian-dbw
Copy link
Member

daxian-dbw commented Jun 14, 2021

Here are my opinions:

Which runtime assembly do we use, windows or linux?

To be consistent with the existing NuGet package, we should use the Unix version of the runtime DLL.
It's not the ideal solution for sure, but should be fine as a temp workaround.

Should the assemblies just be under lib folder? But, I believe lib does not support having RID under it.

I guess for now we can just replace the ref assembly with the runtime assembly and keep the folder structure unchanged.

Can we just have runtime folder? Will the appropriate assembly be picked for compilation?

I don't think the runtime folder alone would work.

@TravisEz13
Copy link
Member Author

I think this PR is ready to merge. Is there anything we are waiting on?

@daxian-dbw daxian-dbw merged commit 046dec4 into PowerShell:master Jun 15, 2021
@rjmholt rjmholt added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Jun 16, 2021
@ghost
Copy link

ghost commented Jun 17, 2021

🎉v7.2.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 deleted the fix-ga-revision branch November 11, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants