Clean up code regarding AppDomain.CreateDomain and AppDomain.Unload
#15554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #15535
AppDomain.CreateAppDomainandAppDomain.Unloadwere used for binary module analysis originally -- loading the binary module into anotherAppDomainso the analysis doesn't pollute the current app domain. However, the code path was disabled when moving to .NET Core because there has been only oneAppDomainsince the beginning in .NET Core.That code path was for analyzing a DLL module (without a module manifest
.psd1file), and it's really not that useful in real world scenarios because all modules should have a module manifest file, which defines what commands are exposed from the module. Therefore, nothing is really affected even though that code path was disabled since 2016.This cleanup removed that code path that creates an
AppDomainall together, as well as the relevant code for cleaning up theAppDomain.Also, a simple
NullReferenceExceptionis fixed inParser.ParseInput.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.