Skip to content

Thread-safe HttpKnownHeaderNames initialization #15519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 1 commit into from
Aug 4, 2021
Merged

Thread-safe HttpKnownHeaderNames initialization #15519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 19 additions & 21 deletions ...ft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/CoreCLR/HttpKnownHeaderNames.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,31 +78,29 @@ internal static class HttpKnownHeaderNames

#endregion Known_HTTP_Header_Names

private static HashSet<string> s_contentHeaderSet = null;
private static readonly HashSet<string> s_contentHeaderSet;

internal static HashSet<string> ContentHeaders
static HttpKnownHeaderNames()
{
get
{
if (s_contentHeaderSet == null)
{
s_contentHeaderSet = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
// Thread-safe initialization.
Copy link
Member

@TravisEz13 TravisEz13 Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Thread-safe initialization.
// Thread-safe initialization because the constructor is only called once per AppDomain.

s_contentHeaderSet = new HashSet<string>(StringComparer.OrdinalIgnoreCase);

s_contentHeaderSet.Add(HttpKnownHeaderNames.Allow);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentDisposition);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentEncoding);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentLanguage);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentLength);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentLocation);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentMD5);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentRange);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentType);
s_contentHeaderSet.Add(HttpKnownHeaderNames.Expires);
s_contentHeaderSet.Add(HttpKnownHeaderNames.LastModified);
}
s_contentHeaderSet.Add(HttpKnownHeaderNames.Allow);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentDisposition);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentEncoding);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentLanguage);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentLength);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentLocation);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentMD5);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentRange);
s_contentHeaderSet.Add(HttpKnownHeaderNames.ContentType);
s_contentHeaderSet.Add(HttpKnownHeaderNames.Expires);
s_contentHeaderSet.Add(HttpKnownHeaderNames.LastModified);
}

return s_contentHeaderSet;
}
internal static HashSet<string> ContentHeaders
{
get => s_contentHeaderSet;
}
}
}