Skip to content

Conversation

@krishnayalavarthi
Copy link
Contributor

PR Summary

'Run as Powershell 7.0' handling when invoking ps scripts, which has commands like calc.exe in some of the folder names.

PR Context

When invoking a script with 'Run as Powershell 7.0' from a path which has commands like calc.exe in some of the folder names, will invoke the calc.exe and execute it. This PR will avoid such invoke.

PR Checklist

@ghost ghost assigned daxian-dbw May 21, 2021
@krishnayalavarthi krishnayalavarthi mentioned this pull request May 21, 2021
22 tasks
@ghost ghost added the Review - Needed The PR is being reviewed label May 29, 2021
@ghost
Copy link

ghost commented May 29, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw
Copy link
Member

@krishnayalavarthi, an issue should be opened before submitting fix for the issue. Can you please open an issue with repros?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 14, 2021
@krishnayalavarthi
Copy link
Contributor Author

Issue addressed here: #15577

@daxian-dbw

This comment has been minimized.

@daxian-dbw daxian-dbw closed this Jun 17, 2021
@daxian-dbw daxian-dbw reopened this Jun 17, 2021
@daxian-dbw daxian-dbw requested review from SteveL-MSFT and removed request for adityapatwardhan June 17, 2021 20:43
@daxian-dbw daxian-dbw assigned TravisEz13 and unassigned daxian-dbw Jun 17, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Jun 25, 2021
@ghost
Copy link

ghost commented Jun 25, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@TravisEz13 TravisEz13 added WG-Security security related areas such as JEA Needs-Triage The issue is new and needs to be triaged by a work group. and removed WG-Security security related areas such as JEA labels May 8, 2023
@ghost ghost removed the Review - Needed The PR is being reviewed label May 8, 2023
@pull-request-quantifier-deprecated

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.wxs : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label May 8, 2023
@TravisEz13 TravisEz13 merged commit facbfd6 into PowerShell:master May 8, 2023
@ghost
Copy link

ghost commented Jun 29, 2023

🎉v7.4.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small Needs-Triage The issue is new and needs to be triaged by a work group.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants