Skip to content

Conversation

@krishnayalavarthi
Copy link
Contributor

PR Summary

'Run as Powershell 7.0' handling when invoking ps scripts, which has commands like calc.exe in some of the folder names.

PR Context

When invoking a script with 'Run as Powershell 7.0' from a path which has commands like calc.exe in some of the folder names, will invoke the calc.exe and execute it. This PR will avoid such invoke.

PR Checklist

@ghost ghost assigned daxian-dbw May 11, 2021
@krishnayalavarthi
Copy link
Contributor Author

@TravisEz13 @SteveL-MSFT

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 12, 2021
@SteveL-MSFT SteveL-MSFT requested a review from TravisEz13 May 12, 2021 19:04
Looks fine

Co-authored-by: Steve Lee <slee@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 12, 2021
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveL-MSFT SteveL-MSFT assigned TravisEz13 and unassigned daxian-dbw May 12, 2021
@TravisEz13
Copy link
Member

There is a conflict, and you didn't give maintainers permission to resolve it for you. Please resolve the conflict.

@krishnayalavarthi
Copy link
Contributor Author

Resolve conflicts button is disabled for me. I see a message "Only those with write access to this repository can merge pull requests."

@ghost
Copy link

ghost commented May 21, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost added the Review - Needed The PR is being reviewed label May 21, 2021
@krishnayalavarthi
Copy link
Contributor Author

I created a new one with the right permissions. #15434

@krishnayalavarthi
Copy link
Contributor Author

image

Disabled 'Resolve Conflicts'

@iSazonov
Copy link
Collaborator

@krishnayalavarthi Since it is simple change you could update your fork, create new branch, add the change and pull new PR.

@ghost ghost removed the Review - Needed The PR is being reviewed label May 21, 2021
@krishnayalavarthi
Copy link
Contributor Author

@iSazonov I actually created a new PR #15434 , still I get the conflicting files error.

@iSazonov
Copy link
Collaborator

@iSazonov I actually created a new PR #15434 , still I get the conflicting files error.

You have used the same branch. I suggest you update your fork with latest commits from PowerShell/master? create new work branch and apply your changes again.

@ghost ghost added the Review - Needed The PR is being reviewed label May 30, 2021
@ghost
Copy link

ghost commented May 30, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw daxian-dbw mentioned this pull request Jun 17, 2021
22 tasks
@daxian-dbw
Copy link
Member

I just realized #15434 was created to replace this PR. I have assigned #15434 to @TravisEz13, also added @SteveL-MSFT to review again.

@daxian-dbw daxian-dbw closed this Jun 17, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants