Skip to content

Add PipelineStoppedException notes to PowerShell API #15324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adityapatwardhan merged 4 commits into from
Jun 3, 2021
Merged

Add PipelineStoppedException notes to PowerShell API #15324

adityapatwardhan merged 4 commits into from
Jun 3, 2021

Conversation

@rjmholt
Copy link
Collaborator

@rjmholt rjmholt commented Apr 29, 2021

PR Summary

Fixes #15173.

Adds doc comments about how PowerShell.Invoke() and PowerShell.InvokeAsync() work with PowerShell.Stop().

PR Checklist

daxian-dbw
daxian-dbw approved these changes Apr 29, 2021
View reviewed changes
@rjmholt @daxian-dbw
Update src/System.Management.Automation/engine/hostifaces/PowerShell.cs
4aaba4e 
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@daxian-dbw
Copy link
Member

daxian-dbw commented Apr 30, 2021

@rjmholt CodeFactor complains about invalid XML doc. Can you take a look and fix them?

adityapatwardhan
adityapatwardhan requested changes May 5, 2021
View reviewed changes
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 5, 2021
@rjmholt @adityapatwardhan
Apply suggestions from code review
e2625fb 
Co-authored-by: Aditya Patwardhan <adityap@microsoft.com>
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label May 5, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label May 13, 2021
@ghost
Copy link

ghost commented May 13, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@daxian-dbw
Copy link
Member

daxian-dbw commented May 13, 2021

@adityapatwardhan Can you review again?

@ghost ghost removed the Review - Needed The PR is being reviewed label May 13, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label May 20, 2021
@ghost
Copy link

ghost commented May 20, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan adityapatwardhan merged commit 50d8507 into PowerShell:master Jun 3, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Jun 3, 2021
@adityapatwardhan adityapatwardhan added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jun 3, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-preview.7 milestone Jun 3, 2021
@ghost
Copy link

ghost commented Jun 17, 2021

🎉v7.2.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Jun 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

Assignees

@adityapatwardhan adityapatwardhan

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.7

Development

Successfully merging this pull request may close these issues.

PowerShell.Stop() behaviour causes very different results between PowerShell.Invoke() and PowerShell.InvokeAsync()

3 participants

@rjmholt @daxian-dbw @adityapatwardhan