Skip to content

Feat: Add Ubuntu 20.04 Support to install-powershell.sh #15095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anmenaga merged 2 commits into from
Apr 5, 2021
Merged

Feat: Add Ubuntu 20.04 Support to install-powershell.sh #15095

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8bf93
Feat: Add Ubunto 20.04 Support to install-powershell.sh
JustinGrote Mar 24, 2021
1ddf948
Version Bump
JustinGrote Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/installpsh-debian.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

#gitrepo paths are overrideable to run from your own fork or branch for testing or private distribution

VERSION="1.2.0"
VERSION="1.2.1"
gitreposubpath="PowerShell/PowerShell/master"
gitreposcriptroot="https://raw.githubusercontent.com/$gitreposubpath/tools"
thisinstallerdistro=debian
Expand Down Expand Up @@ -176,12 +176,12 @@ fi
case $DISTRIB_ID in
ubuntu|linuxmint)
case $DISTRIB_RELEASE in
18.04|16.10|16.04|15.10|14.04)
20.04|18.04|16.10|16.04|15.10|14.04)
Copy link
Collaborator

@iSazonov iSazonov Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove unsupported versions.

Copy link
Contributor Author

@JustinGrote JustinGrote Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSazonov Should I do that in the context of this PR or as a separate one? Also maybe that would be a breaking change for existing CI/CD deployments?

Copy link
Collaborator

@iSazonov iSazonov Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TravisEz13 Could you help please? What versions could we remove without breaking CIs?

Copy link
Contributor Author

@JustinGrote JustinGrote Mar 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the distributions most common to Azure Devops and Github Actions, so the short term ".10" ubuntu releases could probably be dropped, I'd be a little wary of 14.04 though as it may have wide deployment in onprem CI environments like Jenkins, etc.
https://github.com/actions/virtual-environments#available-environments

Copy link
Contributor Author

@JustinGrote JustinGrote Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to master for fixed test.
@iSazonov @TravisEz13 do you want me to drop the unsupported ".04" releases or should that be a separate PR (if at all)?

My opinion is leave it, don't create a potential breaking change but if someone does a net-new install to these and asks for support just direct them to the supported platform document.

Copy link
Collaborator

@iSazonov iSazonov Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release process is completely under the control of MSFT team, and they depend on internal (cloud) projects. So we are waiting for their conclusion.
Current OS support document for .Net 6 https://github.com/dotnet/core/blob/main/release-notes/6.0/6.0-supported-os.md
So we could safely remove 16.10 and 15.10.

Copy link
Member

@TravisEz13 TravisEz13 Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with a separate PR. PowerShell policy is that the .10 releases are community supported. We don't build packages for those releases.

curl https://packages.microsoft.com/config/ubuntu/$DISTRIB_RELEASE/prod.list | $SUDO tee /etc/apt/sources.list.d/microsoft.list
;;
*)
echo "ERROR: unsupported Ubuntu version ($DISTRIB_RELEASE)." >&2
echo "Supported versions: 14.04, 15.10, 16.04, 16.10, 18.04." >&2
echo "Supported versions: 14.04, 15.10, 16.04, 16.10, 18.04, 20.04." >&2
echo "For additional versions open an issue or pull request at: https://github.com/powershell/powershell" >&2
exit 1
;;
Expand Down