Skip to content

Remove unnecessary Array -> List -> Array conversion in ProcessBaseCommand.AllProcesses #15052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjmholt merged 4 commits into from
Apr 12, 2021
Merged

Remove unnecessary Array -> List -> Array conversion in ProcessBaseCommand.AllProcesses #15052

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8316bed
Remove unnecessary Array -> List -> Array conversion
xtqqczze Mar 17, 2021
f8f8550
Fix IDE0025: Use expression body
xtqqczze Mar 17, 2021
2552ca3
Remove redundant initialization
xtqqczze Mar 17, 2021
1e2a12f
Update documentation comments
xtqqczze Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,30 +266,17 @@ private void RetrieveProcessesByInput()
}

/// <summary>
/// Retrieve the master list of all processes.
/// Gets an array of all processes.
/// </summary>
/// <value></value>
/// <value>An array of <see cref="Process"/> components that represents all the process resources.</value>
/// <exception cref="System.Security.SecurityException">
/// MSDN does not document the list of exceptions,
/// but it is reasonable to expect that SecurityException is
/// among them. Errors here will terminate the cmdlet.
/// </exception>
internal Process[] AllProcesses
{
get
{
if (_allProcesses == null)
{
List<Process> processes = new();
processes.AddRange(Process.GetProcesses());
_allProcesses = processes.ToArray();
}

return _allProcesses;
}
}
internal Process[] AllProcesses => _allProcesses ??= Process.GetProcesses();

private Process[] _allProcesses = null;
private Process[] _allProcesses;

/// <summary>
/// Add <paramref name="process"/> to <see cref="_matchingProcesses"/>,
Expand Down