Skip to content

Conversation

@anmenaga
Copy link

@anmenaga anmenaga commented Feb 19, 2021

PR Summary

Experimental feature list is corrupted in powershell.config.json in some OS packages (e.g. PowerShell-7.2.0-preview.3-win-x64.zip and PowerShell-7.2.0-preview.3-win-x64.msi and nightly builds).
This results in all experimental features disabled by default (unless overridden by another-scoped config).
This PR fixes experimental feature list in powershell.config.json.

Problem screenshot:
ExpFeaturesBroken

PR Context

While fixing another issue, #14748 changed the type of collection with experimental features from System.Array to System.Collections.ArrayList.
The later used the ArrayList.Add(Object) method returns an index at which the value has been added, which ends up in the output stream, contaminating the expected output with experimental features.

PR Checklist

@anmenaga anmenaga added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 19, 2021
@anmenaga anmenaga changed the title Fix broken experimental feature list in powershell.config.json Fix experimental feature list in powershell.config.json Feb 19, 2021
@adityapatwardhan adityapatwardhan merged commit e0b5414 into PowerShell:master Feb 22, 2021
@ghost
Copy link

ghost commented Mar 16, 2021

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants